Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(apiserver): Check that app is bound on API routes #3228

Merged
merged 1 commit into from
Sep 27, 2024
Merged

fix(apiserver): Check that app is bound on API routes #3228

merged 1 commit into from
Sep 27, 2024
+493 −446

Conversation

silvestre
Copy link
Member

Issue

It was possible to get information for a currently unbound app from the
API server

Fix

Check if the app is currently bound to the service on all routes.

@silvestre silvestre added allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. and removed allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. labels Sep 26, 2024
@silvestre
chore(apiserver): Clean up routes
630d7e3 
# Issue

It was possible to get information for a currently unbound app from the
API server

# Fix

Check if the app is currently bound to the service on all routes.
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
15.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@silvestre silvestre marked this pull request as ready for review September 27, 2024 13:39
@silvestre silvestre added the bug label Sep 27, 2024
@silvestre silvestre changed the title chore(apiserver): Clean up routes fix(apiserver): Check that app is bound on API routes Sep 27, 2024
@asalan316 asalan316 added allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. and removed allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. labels Sep 27, 2024
@asalan316
Copy link
Contributor

Somehow acceptance tests were skipped. I re-enabled them. May be if was due to the sequence of labels

@silvestre silvestre merged commit a59b89c into main Sep 27, 2024
52 of 59 checks passed
@silvestre silvestre deleted the clean-up-routes branch September 27, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asalan316 asalan316 asalan316 approved these changes

@joergdw joergdw joergdw approved these changes

Assignees
No one assigned
Labels
allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silvestre @asalan316 @joergdw